Skip to content

Fix rust-analyzer warnings#101

Open
scaryrawr wants to merge 3 commits intomainfrom
fix-warnings
Open

Fix rust-analyzer warnings#101
scaryrawr wants to merge 3 commits intomainfrom
fix-warnings

Conversation

@scaryrawr
Copy link
Owner

GPT-5.2

Copilot AI review requested due to automatic review settings January 30, 2026 15:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses rust-analyzer warnings by refactoring code to follow idiomatic Rust patterns. The changes simplify verbose constructs, remove unnecessary annotations, and eliminate unused imports without altering any functionality.

Changes:

  • Simplified Result-to-bool conversions using .is_ok() instead of match expressions
  • Removed unnecessary explicit lifetime annotations where Rust can infer them
  • Replaced verbose match expressions with cleaner if let patterns
  • Removed unused result assignments for functions returning unit type
  • Cleaned up unused imports

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libraries/websl/src/lib.rs Replaced match expressions with .is_ok() in three train functions (add_d51, add_logo, add_c51)
libraries/libsl/src/print_car.rs Removed unnecessary explicit lifetime annotations from car_text function
libraries/libsl/src/mvaddstr.rs Simplified negated condition from !(x < 0) to x >= 0
libraries/libsl/src/add_smoke.rs Removed unused result assignments (_ =) for mvaddstr calls
libraries/libsl/src/add_man.rs Removed unused result assignment for mvaddstr call
apps/sl/src/main.rs Replaced match expressions with if let patterns for cleaner error handling
apps/sl/src/cli.rs Removed unused command import from clap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants