Workload Plane isolation detection and remediation#5031
Open
TeddyAndrieux wants to merge 5 commits into
Open
Conversation
Ship and deploy the node-warden-operator kustomize addon (github.com/scality/node-warden-operator v1.0.0) into the metalk8s-monitoring namespace, labelling its ServiceMonitor so Prometheus scrapes it, and add it to the deployment sanity checks. The operator watches node conditions through NodeRemediationPolicy custom resources; the default policy itself is added separately. Issue: MK8S-320
Ship the default cluster-scoped NodeRemediationPolicy that taints a node NoExecute when it reports the WorkloadPlaneNetworkUnavailable condition (removing the taint on recovery), applied only once the operator is Ready so its validating webhook can be reached. Tolerate that taint on node-exporter and fluent-bit so metrics and log shipping survive on a remediated node. Issue: MK8S-320
Ship the Workload Plane isolation alerts next to the component that produces each signal: NodeWorkloadPlaneUnavailable (the condition) with node-problem-detector, and NodeWorkloadPlaneRemediated (the taint) plus WorkloadPlaneOutage (majority affected, guard-suppressed) with node-warden-operator. Register them in the alert tree: the two node alerts under Node (warning) and WorkloadPlaneOutage under a new Network critical roll-up feeding the cluster-at-risk alert. Issue: MK8S-321
Add a segregated-network BDD suite exercising the full flow: cut a node's Workload Plane (link-down and raw-table block), assert the WorkloadPlaneNetworkUnavailable condition on that node only, the NoExecute taint after debounce, the node leaving the Service endpoints, the condition and remediation alerts firing, and recovery (taint, endpoints and alerts cleared) on restore. Also cover the guards: no remediation on a calico-node restart or a sub-debounce blip, and guard suppression plus the WorkloadPlaneOutage alert on a majority outage. The rollout-restart step is extracted to a shared conftest step. Issue: MK8S-323
Contributor
Hello teddyandrieux,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Contributor
|
LGTM |
Collaborator
Author
|
/create_integration_branches |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: The following options are set: create_integration_branches |
eg-ayoub
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component: salt, containers, build, tests
Context:
MetalK8s already detects Workload Plane (WP) isolation: node-problem-detector
(shipped in 133.0.12) exposes the
WorkloadPlaneNetworkUnavailablenodecondition when a node can no longer reach the majority of its peers over the
Workload Plane. This PR adds the remediation that acts on that condition, the
alerts that surface it, and an end-to-end test.
Summary:
node-warden-operatorv1.0.0 as a kustomize addon in themetalk8s-monitoringnamespace, ordered after Prometheus (it ships aServiceMonitor, labelled so our Prometheus scrapes it) and cert-manager (its
webhook certificate). Added to the deployment sanity checks.
workload-plane-isolation, a cluster-scopedNodeRemediationPolicy): when a WP node reportsWorkloadPlaneNetworkUnavailable, apply a reversiblenode.scality.io/workload-plane-unreachable:NoExecutetaint to drain it anddrop it from Service endpoints, then remove the taint once WP connectivity
recovers. A guard suppresses remediation when the majority of nodes are
affected (cluster-wide outage). Infra components tolerate the taint.
NodeWorkloadPlaneUnavailable(node-problem-detector) for the condition, andNodeWorkloadPlaneRemediated+WorkloadPlaneOutage(node-warden-operator)for the taint / suppressed-guard cases; also registered in the lib-alert-tree.
drained and recovers (link-down and blocked modes), while a Calico rolling
restart, a short blip, and a majority outage do not trigger remediation.
Acceptance criteria:
workload_plane_isolation.featureon amulti-node, segregated-network cluster.
and
NodeWorkloadPlaneUnavailable/NodeWorkloadPlaneRemediatedfire; allrevert once connectivity is restored.
WorkloadPlaneOutageand does not taintany node.
Fixes: MK8S-320, MK8S-321, MK8S-323