MK8S-81 - documentation: Add README, LICENSE, CONTRIBUTING and CODEOWNERS documents. - #17
Merged
Merged
Conversation
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
vdaviot
changed the title
MK8S-82 - documentation: Add basic AI generated docMK8S-81 - documentation: Add basic AI generated doc
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
vdaviot
changed the title
MK8S-81 - documentation: Add basic AI generated docMK8S-81 - documentation: Add README, LICENSE, CONTRIBUTING and CODEOWNERS documents.
| 4. Run the full validation suite before pushing: | ||
|
|
||
| ```bash | ||
| make manifests generate fmt vet lint test |
Contributor
There was a problem hiding this comment.
nit: maybe an umbrella recipe against make that triggers it all would be nice for contributors
Contributor
Author
|
I don't think we should, we're supposed to stay as close as possible to operator-sdk scaffolding, adding makefile recipe like this would push us in the other direction. @eg-ayoub @ezekiel-alexrod |
Contributor
Author
|
I'm closing this, will address the comment in another PR if need be |
ezekiel-alexrod
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch name is not right, should be
improvement/MK8S-81-documentation