fix: include AAAA recordsets in Records() - #1
Merged
Conversation
Records() only ever returned A, TXT and CNAME recordsets from Designate. Any existing AAAA recordset was invisible to external-dns's planner, so it treated it as permanently missing and retried CreateRecordSet every sync interval, failing forever with 409 duplicate_recordset once the record already existed. Also adds a devstack integration check that seeds an AAAA recordset directly in Designate and asserts the webhook's GET /records reports it back. The existing checks only ever exercise A/TXT since external-dns's fake source never emits AAAA, so they wouldn't have caught this bug.
external-dns's endpoint.NewEndpointWithTTL trims the trailing dot from DNSName, so the /records response has "aaaa-webhook-test.example.com" without a trailing dot, not "aaaa-webhook-test.example.com.". The AAAA fix itself was correct - confirmed by the actual CI run, which showed the record present in the response before this assertion rejected it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records()only ever returnedA,TXT, andCNAMErecordsets from Designate — any existingAAAArecordset was invisible to external-dns's planner.CreateRecordSeton every sync, failing forever with409 duplicate_recordset. Observed in production as ~80k consecutive failed reconciles over 56+ days.ApplyChanges/CreateRecordSetnever had this restriction — Designate accepted AAAA records fine, it's purely a gap in the read-back path.Changes
internal/designate/provider/provider.go: addendpoint.RecordTypeAAAAto the type allowlist inRecords().internal/designate/provider/provider_test.go: extendTestDesignateRecordswith an AAAA recordset case..github/workflows/devstack.yml: add an integration check that seeds an AAAA recordset directly in Designate and asserts the webhook'sGET /recordsreports it back. The existing checks only exercise A/TXT since external-dns'sfakesource never emits AAAA, so they wouldn't have caught this.Test plan
go test ./...passes locallygo build ./...passes locally