Improved test failure display on the ScalaTest View#11
Conversation
Conflicts: org.scala-ide.sdt.scalatest.tests/src/scala/tools/eclipse/scalatest/launching/ScalaTestLaunchDelegateTest.scala org.scala-ide.sdt.scalatest/src/scala/tools/eclipse/scalatest/launching/ScalaTestLaunchDelegate.scala
ghost
assigned
|
Hi rlegendi, I wonder if the following commit (included in 0.9.2 that we are releasing) is trying to do the same thing as you do:- May be instead of the 'Message: ' prefix, the exception class name is better? |
|
Hi cheeseng, Thanks for the update! Unfortunately I've totally messed up my workspace a week ago and I wasn't able to clean it up yet :-) On first sight, it seems the changeset you linked is indeed similar to the solution I proposed here. The only difference is that I've also updated the The reason why I used the exception because Specs2 shows the failure in its message. Also, showing the exception name could be useful in some cases in my experience (like if it was an |
|
@cla-bot[bot] check |
|
Hi @rlegendi, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot[bot] check |
|
Hi @rlegendi, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
The cla-bot has been summoned, and re-checked this pull request! |
4 participants
Hi all!
Hope this is the proper repo to submit any pull requests :-) I'm working on the Specs2 integration through ScalaTest plugin and got a feedback about a minor issue. I thought the best approach would be to extend the ScalaTest plugin so everyone could benefit from the patch.
The issue is that if a test if failed, its reason is not reported in any way at the ScalaTest view.
The default Eclipse JUnit runner view for instance, looks like this:
Now, the ScalaTest view had nothing similar:
So in this pull request I extended the view with the proper error message display that caused the test to fail:
I would also welcome any code review, because after many modifications I still feel the addition a bit clumsy here and here. Thanks in advance!
I have also found an absolute library reference in the project classpath entries, changed it to relative (so after checking out the project it has no errors hopefully).
Thanks in advance!