Parse Java annotations on wildcard type arguments#26187
Open
mkurz wants to merge 1 commit into
Open
Conversation
Java permits type-use annotations before wildcard type arguments, for example Function<@nullable ? super String, @nullable ? extends Object>. Consume annotations before checking for a wildcard type argument so the Java parser accepts that syntax. Add a positive Java parser regression test covering annotated wildcard bounds.
1332866 to
91b53d5
Compare
Contributor
Author
|
Backport for Scala 2: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java permits type-use annotations before wildcard type arguments, for example
Reproduce
You can use this repo's test files:
Java however can compile it:
How much have you relied on LLM-based tools in this contribution?
Not at all (update: after the GitHub actions jobs failed I used codex for analysing the code and find out what broke, that lead to force push)
How was the solution tested?
New automated tests (including the issue's reproducer)
Plus Manual tests
See also