Open
Conversation
sjrd
requested changes
Jul 13, 2020
Member
sjrd
left a comment
sjrd
left a comment
There was a problem hiding this comment.
Thanks for the PR. This was clearly missing. I have two comments: one nitpick and a more important one.
| if (isSnapshot.value) | ||
| Seq.empty | ||
| else { | ||
| val a = baseDirectory.value.toURI |
Member
There was a problem hiding this comment.
baseDirectory depends on the project, whereas the URL is the same for all projects, so this will only work for the root project. Either move those options to the root project only (which is fine because that's the only project that gets published) or apply the following change, so that it would work in all projects:
Suggested change
| val a = baseDirectory.value.toURI | |
| val a = (baseDirectory in LocalRootProject).value.toURI |
Comment on lines
+18
to
+20
| if (isSnapshot.value) | ||
| Seq.empty | ||
| else { |
Member
There was a problem hiding this comment.
In our coding style, if one of the two branches of the if needs braces, then the other one must have braces as well:
Suggested change
| if (isSnapshot.value) | |
| Seq.empty | |
| else { | |
| if (isSnapshot.value) { | |
| Seq.empty | |
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently I'm seeing the following in the artifacts on Maven Central: