Repository navigation
Say what ran on x86_64 in the 7.1.5.5 and 6.1.6.5 notes - #28
Merged
Merged
Conversation
Both notes said x86_64 was not run on a device. That was true when they shipped, but the CI runs added afterwards covered Audio, Video and Full on the same FFmpegKit libraries, and published 7.1.5.4 Audio was seen failing with the RELRO error on x86_64. 6.1.6.4 itself never ran on x86_64, so that note's sentence about the old package stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the documentation-only updates describing post-release x86_64 testing in two older-track release notes.
No open issues 🎉
What changed in this PR
Updates two older-track release notes to reflect post-release x86_64 emulator testing. These are documentation-only changes; no new release is triggered.
Changes:
- Records successful
AudioandVideodevice checks and aFullexample-app conversion using later builds of the same native libraries. - Preserves the distinction from testing the published packages and identifies the five variants still untested on
x86_64. - Documents the observed GNU RELRO failure in published
7.1.5.4Audio.
| File | Description |
|---|---|
docs/release-notes/7.1.5.5.md |
Adds post-release x86_64 coverage and confirms the earlier Audio RELRO failure. |
docs/release-notes/6.1.6.5.md |
Adds post-release x86_64 coverage while preserving the earlier release’s testing limits. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both notes said
x86_64was not run on a device. That was true when they shipped, but CI runs added since have covered it, so the notes now understate what was tested.This changes only those lines, and the merge doesn't release anything:
auto-release.ymlignores edited notes (--diff-filter=A).What changes
7.1.5.5.mdand6.1.6.5.md, last line: says which variants ran onx86_64after the release, and which five didn't.7.1.5.5.md, line 17: the claim thatAudiocarries the RELRO defect onx86_64is now backed by a real failure of published7.1.5.4.6.1.6.5.md, line 17: left alone.6.1.6.4never ran onx86_64, so "Nor wasx86_64" is still accurate there.Evidence
All of it is from the
x86_64emulator logs.Audio,Videoonnet8.0-android34.0, API 31 and 35, FFmpegKit7.1.7and6.0.4passed=15 failed=0,ffmpeg=n7.1.5/ffmpeg=n6.1.6on all 8 legsFull) onnet10.0-android36.0, API 35, both trackssample run passed7.1.5.4Audioonnet8.0-android34.0, API 31can't enable GNU RELRO,passed=1 failed=14The first two rows are
-betabuilds of the same FFmpegKit libraries, not the published packages. The notes say so.Already applied
The same lines are live on the 7.1.5.5 and 6.1.6.5 GitHub Releases, as the maintainer approved. Nothing else in those releases changed, and Latest stays on
v8.1.3.1: the edit passed--latest=false, because GitHub gives the label to the newest release otherwise (see #26).If the wording changes in review, those two releases need the same edit.
Not covered
Min,MinGpl,Https,HttpsGplandFullGplhave still not run onx86_64on these tracks. Both notes say so.🤖 Generated with Claude Code