WIP: Big endian support and basic raw UDP framebuffer stream#85
Draft
kleinesfilmroellchen wants to merge 5 commits into
Draft
WIP: Big endian support and basic raw UDP framebuffer stream#85kleinesfilmroellchen wants to merge 5 commits into
kleinesfilmroellchen wants to merge 5 commits into
Conversation
Makes all tests pass on big-endian (tested MIPS32 R2), except for PXMULTI which is inherently little-endian. Fixing that would be more involved and degrade performance. Note: whether outputs work or have flipped colors has not been tested yet.
| } | ||
|
|
||
| while i < loop_end { | ||
| // BUG: byte order is inverted on big-endian |
Contributor
Author
There was a problem hiding this comment.
oops, that was a debugging comment, this should be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ultimate goal is to make breakwater compatible with my TP-Link Archer C7 router running OpenWRT on mips-unknown-linux-musl (MIPS32, big-endian). This has three main parts:
prometheus_exporterdoesn’t compile on 32-bit systems since it needs 64-bit atomics. I’m looking forward to Pixelflut on Nintendo 3DS :3RGBAinstead of theABGRon little-endian. This may cause issues with outputs which assume the framebuffer endianness, but I am unable to test any of the existing outputs on that router.