This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Repository navigation
feat: deprecate package - #206
Merged
Merged
Conversation
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (115)
💤 Files with no reviewable changes (93)
📝 WalkthroughWalkthrough
ChangesDeprecation, workspace cleanup, and bundler migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
C. Spencer Beggs (spencerbeggs)
force-pushed
the
feat/deprecate-package
branch
from
June 24, 2026 02:59
7784089 to
6090f49
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
C. Spencer Beggs (spencerbeggs)
force-pushed
the
feat/deprecate-package
branch
from
June 24, 2026 03:01
6090f49 to
735cef4
Compare
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
C. Spencer Beggs (spencerbeggs)
force-pushed
the
feat/deprecate-package
branch
from
June 24, 2026 03:03
735cef4 to
49a9db2
Compare
![savvy-web-bot[bot]](https://avatars.githubusercontent.com/in/1855974?s=60&v=4){kind=small}
| "@savvy-web/rslib-builder": minor | ||
| --- | ||
|
|
||
| ## Breaking Changes |
Contributor
There was a problem hiding this comment.
The changeset bumps minor but the body is headed ## Breaking Changes. These signal opposite things to consumers and to changesets' versioning. If the public @savvy-web/rslib-builder API surface is unchanged (this is a deprecation notice + internal build-system swap), consider dropping the "Breaking Changes" heading so it reads as a routine deprecation. If something consumer-facing genuinely breaks, the bump should be major. Either way, worth reconciling the two.
Minor: the file also has no trailing newline.
| "@rsbuild/plugin-react": "^2.0.0", | ||
| "@rslib/core": "^0.22.0", | ||
| "@types/node": "catalog:silkPeers", | ||
| "@types/node": "^26.0.0", |
Contributor
There was a problem hiding this comment.
@types/node was un-catalog'd to ^26.0.0 while every sibling peer (@types/react, typescript, @typescript/native-preview, etc.) stays on catalog:silkPeers. Two things to confirm:
- Is this intentional (e.g.
@types/nodewas removed from thesilkPeerscatalog and now needs a literal range), or an oversight? ^26.0.0requires a major newer than this package's declared runtime floor (rootengines.nodeis>=24.11.0). A consumer on Node 24/25 with matching@types/node@24/25would fail this required peer. If 24.11 support is real,>=24.11.0(or>=24) would be a looser, more accurate constraint. Given the package is being deprecated this is low-stakes, but flagging in case the range is unintended.
Contributor
Code ReviewCurrent Commit: SummaryThis PR deprecates The scope is large but the changes are coherent and internally consistent. All validation checks pass:
What looks good
Notes (all minor, none blocking)
Nothing here blocks the deprecation. Not submitting a formal approval since the inline points are open for the author to confirm. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
C. Spencer Beggs (spencerbeggs)
added a commit
that referenced
this pull request
Jun 24, 2026
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Deprecation Notice
@savvy-web/bundlerinstead.Chores