Repository navigation
chore: package deprecation - #98
Conversation
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
Current Commit: b68a2b5
Summary
All five CI checks pass (Tests, Markdown, Code Quality, Conventional Commits, PR Title Validation). The build system migration from @savvy-web/rslib-builder → @savvy-web/bundler looks clean: rslib.config.ts is deleted, savvy.build.ts is well-structured, tsdoc.json and tsconfig.json are updated consistently, and the turbo.json task graph correctly threads the new build:meta step into the pipeline. The publishConfig.targets simplification is a nice cleanup.
One issue needs fixing before merge, plus one minor observation:
Issues
Deprecation notice text is copy-pasted from a different package
Both README.md and package/README.md say:
"Its lint-staged handlers now ship in
@savvy-web/silk…savvy lintreplacessavvy-lint."
This package is a changelog formatter and changeset pipeline — it has no lint-staged handlers and no savvy-lint bin. The correct migration is already documented in the changeset file (cozy-grapes-yell.md): point config at @savvy-web/silk/changesets/changelog and replace savvy-changesets with savvy changeset.
Since package/README.md is what gets published to npm, users reading the package page will be given incorrect migration instructions. See inline comments on both files.
Stale @rslib/core devDependency (minor)
rslib.config.ts is deleted but @rslib/core: "^0.22.0" remains in devDependencies. If @savvy-web/bundler doesn't peer-require rslib, this entry can be dropped to keep the published manifest clean.
What looks good
- The
.changeset/cozy-grapes-yell.mdentry is accurate and comprehensive — correct package names, correct bin replacements, clear migration steps. savvy.build.tsis a clean replacement forrslib.config.ts;import.meta.mainguard is the right pattern for dual use as a module and a runnable script.@sincesyntaxKindchange from"modifier"→"block"is applied consistently across bothsavvy.build.tsandtsdoc.json.turbo.jsonnow correctly wiresbuild:metabetweenbuild:devandbuild:prod, and the expandedinputsglobs (*.ts,*.mts,*.cts) will prevent stale cache hits from TypeScript-adjacent config files.silk-update-actionv2 → v3 bump is a routine maintenance update.
Signed-off-by: C. Spencer Beggs <spencer@savvyweb.systems>
Code ReviewCurrent Commit: e68ee1a SummaryThis PR deprecates Validation Checks
What Changed
Positive ObservationsThe changeset (
|
Signed-off-by: C. Spencer Beggs spencer@savvyweb.systems