Skip to content

fix: update save button text for clarity and improve theme panel desc… - #5

Merged
roble merged 1 commit into
mainfrom
dev
Apr 20, 2026
Merged

fix: update save button text for clarity and improve theme panel desc…#5
roble merged 1 commit into
mainfrom
dev

Conversation

@roble

@roble roble commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

This pull request makes several improvements to the theme customization UI and related tests, focusing on clearer language and improved layout, as well as simplifying test setup for theme configuration.

UI/UX Improvements:

  • Updated the theme customization panel to use more inviting and user-friendly language, changing descriptions like "Adjust colors, font, and radius." to "Add your own flavor" in ThemePanel.vue. [1] [2]
  • Improved the layout of the theme panel header for better responsiveness and visual hierarchy, including changes to class names for wrapping and ordering elements.
  • Simplified the save button labeling and tooltips throughout the UI from "Save as new theme" to "Save as" for consistency and clarity, including related comments and dropdown menu items. [1] [2] [3] [4]

Testing Improvements:

  • Refactored theme configuration tests to use direct laravel.config calls instead of custom helper functions, making tests more straightforward and reliable.

These changes enhance both the end-user experience and the maintainability of the codebase.

Copilot AI review requested due to automatic review settings April 20, 2026 20:06
@roble
roble merged commit c84feb0 into main Apr 20, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the theme customization UI copy/layout and aligns theme “save as” labeling, while simplifying e2e test setup for theme config flags.

Changes:

  • Adjusted ThemePanel header layout for better wrapping/responsiveness and updated panel description copy.
  • Renamed “Save as new theme” to “Save as” in the ThemePanel UI and related documentation.
  • Simplified e2e theme config tests by using laravel.config() instead of a PHP helper for toggling themes.enabled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/e2e/themes-config.spec.ts Switches test setup/teardown and toggles to laravel.config('themes.enabled', …)
resources/js/components/ThemePanel.vue Updates header copy/layout and changes “Save as new theme” → “Save as”
CLAUDE.md Updates documentation to reflect the new “Save as” label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</SheetTitle>
<SheetDescription class="sr-only">
{{ $t('Adjust colors, font, and radius.') }}
{{ $t('Add your own flavor') }}

Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SheetDescription is visually hidden (sr-only) and typically provides the dialog’s accessible description. Replacing the functional description with a slogan (“Add your own flavor”) makes the accessible description less informative for screen-reader users; consider keeping a descriptive sentence about what can be customized (and optionally use the slogan in visible text instead).

Suggested change
{{ $t('Add your own flavor') }}
{{
$t(
'Customize your theme colors, fonts, spacing, and other appearance settings.',
)
}}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants