Skip to content

Refactor theme management and disable modal in ThemePanel #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roble merged 2 commits into from
Apr 18, 2026
Merged

Refactor theme management and disable modal in ThemePanel #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e3921
fix: disable modal for Sheet component in ThemePanel
roble Apr 16, 2026
b6ff458
refactor: replace FIELD_DEFS with themeFields for improved theme mana…
roble Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions resources/js/components/ThemePanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ import {
setProperty,
} from '../utils/theme';

import { FIELD_DEFS } from '../fields';
import { themeFields } from '../fields';

// ── Page props ────────────────────────────────────────────────────────────────

Expand Down Expand Up @@ -172,10 +172,10 @@ async function selectTheme(id: string): Promise<void> {
// ── Fields with values ────────────────────────────────────────────────────────

const fields = reactive<FieldState[]>(
FIELD_DEFS.map((f) => ({ ...f, value: '' })),
themeFields().map((f) => ({ ...f, value: '' })),
);

const uniqueGroups = FIELD_DEFS.filter((f) => f.group)
const uniqueGroups = themeFields().filter((f) => f.group)
.map((f) => f.group!)
.filter((g, i, arr) => arr.findIndex((x) => x.name === g.name) === i);
Comment on lines 174 to 180

Copilot AI Apr 18, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

themeFields() is invoked twice during setup (for fields and uniqueGroups), which regenerates the full field definition list twice. Consider calling themeFields() once (e.g., const fieldDefs = themeFields()) and reusing it for both to avoid duplicate work and keep any per-call object instances consistent.

Copilot uses AI. Check for mistakes.

Expand Down Expand Up @@ -811,10 +811,10 @@ const dialogCommandOpen = ref(false);
</Teleport>

<!-- Sheet — DialogPortal inside SheetContent handles its own teleport to body -->
<Sheet v-model:open="sheetOpen">
<Sheet v-model:open="sheetOpen" :modal="false">
<SheetContent
side="right"
class="flex flex-col gap-0 p-0 shadow-2xl sm:w-110 sm:max-w-none [&>button:last-child]:hidden"
class="flex flex-col gap-0 p-0 shadow-2xl sm:w-105 sm:max-w-none [&>button:last-child]:hidden"
overlay-class="bg-black/5 blur-sm"
>
<TooltipProvider>
Expand Down
Loading
Loading