Skip to content

fix: bind FrontendConfig to return 'vue' framework in ThemesConfigTes… - #10

Merged
roble merged 1 commit into
mainfrom
dev-v2
Jun 7, 2026
Merged

fix: bind FrontendConfig to return 'vue' framework in ThemesConfigTes…#10
roble merged 1 commit into
mainfrom
dev-v2

Conversation

@roble

@roble roble commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the ThemesConfigTest to mock the FrontendConfig service, ensuring that the getFramework() method always returns 'vue' during tests. This helps to make the tests more predictable and independent of the actual frontend configuration.

Test configuration improvements:

  • Added a binding in the test setup to override the FrontendConfig service, forcing getFramework() to return 'vue' for all tests in ThemesConfigTest.php.
  • Imported the FrontendConfig class at the top of the test file to support the new binding.

Copilot AI review requested due to automatic review settings June 7, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes ThemesConfigTest more deterministic by overriding the FrontendConfig service in the test container so that getFramework() always resolves to 'vue', removing dependency on the real frontend configuration during these feature tests.

Changes:

  • Import App\Services\FrontendConfig in ThemesConfigTest.php.
  • Bind FrontendConfig in setUp() to an override implementation returning 'vue' from getFramework().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roble
roble merged commit f43aa4e into main Jun 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants