Conversation
There was a problem hiding this comment.
Pull request overview
This pull request makes ThemesConfigTest more deterministic by overriding the FrontendConfig service in the test container so that getFramework() always resolves to 'vue', removing dependency on the real frontend configuration during these feature tests.
Changes:
- Import
App\Services\FrontendConfiginThemesConfigTest.php. - Bind
FrontendConfiginsetUp()to an override implementation returning'vue'fromgetFramework().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ThemesConfigTestto mock theFrontendConfigservice, ensuring that thegetFramework()method always returns'vue'during tests. This helps to make the tests more predictable and independent of the actual frontend configuration.Test configuration improvements:
FrontendConfigservice, forcinggetFramework()to return'vue'for all tests inThemesConfigTest.php.FrontendConfigclass at the top of the test file to support the new binding.