Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small consistency cleanups in the Settings module by standardizing backend validation rule phpdoc types and reordering frontend Vue imports for readability.
Changes:
- Update
rules()return phpdoc annotations to referenceValidationRule(via import) instead of a fully-qualified name. - Add
ValidationRuleimports to the affected LaravelFormRequestclasses. - Reorder
SettingsLayout/PageHeaderimports in Settings-related Vue pages.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/js/pages/Profile/Edit.vue | Reorders SettingsLayout and PageHeader imports. |
| resources/js/pages/Profile/ChangePassword.vue | Reorders SettingsLayout import relative to other imports. |
| resources/js/pages/Profile.vue | Reorders SettingsLayout import relative to other imports. |
| app/Http/Requests/UpdateProfileInfoRequest.php | Imports ValidationRule and uses it in the rules() phpdoc return type. |
| app/Http/Requests/UpdateProfileAvatarRequest.php | Imports ValidationRule and uses it in the rules() phpdoc return type. |
| app/Http/Requests/UpdatePasswordRequest.php | Imports ValidationRule and uses it in the rules() phpdoc return type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
6
| use Illuminate\Contracts\Validation\ValidationRule; | ||
| use Illuminate\Foundation\Http\FormRequest; |
Comment on lines
+5
to
6
| use Illuminate\Contracts\Validation\ValidationRule; | ||
| use Illuminate\Foundation\Http\FormRequest; |
Comment on lines
+5
to
6
| use Illuminate\Contracts\Validation\ValidationRule; | ||
| use Illuminate\Foundation\Http\FormRequest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily addresses minor code cleanup and consistency improvements across several backend request files and frontend Vue component imports. The main focus is on standardizing type usage in validation rules and organizing import statements for better readability.
Backend validation improvements:
rules()method return docblock forUpdatePasswordRequest,UpdateProfileAvatarRequest, andUpdateProfileInfoRequestto useValidationRuleinstead of the fully qualified interface, improving code clarity and consistency. [1] [2] [3]ValidationRuleimport to the top of each corresponding request file for proper type referencing. [1] [2] [3]Frontend import organization:
Profile.vueandChangePassword.vueto place theSettingsLayoutimport above other imports, aligning with project conventions. [1] [2]Edit.vueto placeSettingsLayoutbeforePageHeader, improving readability.