Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
NewCommandresolves the skeleton package version for new Saucebase applications, ensuring it always installs the latest stable release instead of accidentally installing a development version. It also introduces comprehensive tests for this logic. The main changes are grouped below:Improvements to Skeleton Version Resolution:
dev-mainwhen offline or when the latest version can't be determined. If offline, it falls back to a numeric constraint defined by the newSKELETON_FALLBACKconstant (^2.0). [1] [2]latestVersionmethod now accepts a package name parameter and queries Packagist dynamically, rather than being hardcoded for the installer package.Testing Enhancements:
NewCommandTestwith a testable subclass to verify that the skeleton is pinned to the latest stable release, correctly falls back when offline, and respects command options. This ensures robust coverage of the new version resolution logic.