Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the casing of the @modules/billing import path for shared billing TypeScript types in the Vue UI, avoiding case-sensitive module resolution failures on Linux/macOS filesystems and keeping imports consistent with existing module-style imports in the repo.
Changes:
- Updated type import path casing from
@modules/Billing/...to@modules/billing/...in key billing UI surfaces. - Aligns component/page imports with the already-lowercased module asset import usage elsewhere (e.g.,
@modules/billing/...).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/js/vue/pages/Checkout.vue | Fixes CheckoutSession type import path casing to @modules/billing/.... |
| resources/js/vue/components/ProductSection.vue | Fixes Product type import path casing to @modules/billing/.... |
| resources/js/vue/components/ProductCard.vue | Fixes Price/Product type import path casing to @modules/billing/.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several import statements to fix the casing of the
@modules/billingpath, ensuring consistency and preventing potential module resolution issues. The changes affect type imports in multiple Vue components and pages.Import path casing fixes:
@modules/Billing/resources/js/typesto@modules/billing/resources/js/typesinProductCard.vue,ProductSection.vue, andCheckout.vueto ensure correct module resolution and consistency. [1] [2] [3]