feat: add terms acceptance checkbox and validation - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a required "Terms of Service and Privacy Policy" acceptance checkbox to the registration process, ensuring users must explicitly agree before registering. It updates both the React and Vue registration forms, adds server-side validation and error messaging, and updates related tests to cover the new requirement. Additionally, it makes minor UI consistency improvements to login and registration links.
Registration Flow Updates:
Register.tsx) and Vue (Register.vue) registration forms, including UI, validation, error display, and disabling the register button until all fields (including terms) are completed. [1] [2] [3] [4] [5] [6] [7] [8] [9]RegisterRequest.phpto require thetermsfield to be accepted and provide a custom error message if not.Testing Updates:
RegisterTest.phpto include thetermsfield and added a test to ensure terms acceptance is validated. [1] [2] [3] [4] [5]RegisterPage.ts) and tests to interact with the new checkbox, verify its visibility, and ensure the register button is only enabled when all fields (including terms) are completed. [1] [2] [3] [4] [5]UI Consistency Improvements:
/70) variant for improved clarity. [1] [2] [3] [4]whitespace-nowrap. [1] [2]