Skip to content

feat: add terms acceptance checkbox and validation - #47

Merged
sauce-base merged 1 commit into
mainfrom
dev-v2
Jul 14, 2026
Merged

feat: add terms acceptance checkbox and validation#47
sauce-base merged 1 commit into
mainfrom
dev-v2

Conversation

@sauce-base

Copy link
Copy Markdown
Collaborator

This pull request introduces a required "Terms of Service and Privacy Policy" acceptance checkbox to the registration process, ensuring users must explicitly agree before registering. It updates both the React and Vue registration forms, adds server-side validation and error messaging, and updates related tests to cover the new requirement. Additionally, it makes minor UI consistency improvements to login and registration links.

Registration Flow Updates:

  • Added a required "Terms of Service and Privacy Policy" checkbox to both React (Register.tsx) and Vue (Register.vue) registration forms, including UI, validation, error display, and disabling the register button until all fields (including terms) are completed. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Server-side: Updated RegisterRequest.php to require the terms field to be accepted and provide a custom error message if not.

Testing Updates:

  • Updated feature tests in RegisterTest.php to include the terms field and added a test to ensure terms acceptance is validated. [1] [2] [3] [4] [5]
  • Updated Playwright E2E page object (RegisterPage.ts) and tests to interact with the new checkbox, verify its visibility, and ensure the register button is only enabled when all fields (including terms) are completed. [1] [2] [3] [4] [5]

UI Consistency Improvements:

  • Updated login and register page links to use a consistent color and removed the faded (/70) variant for improved clarity. [1] [2] [3] [4]
  • Ensured the "Forgot your password?" link does not wrap awkwardly by adding whitespace-nowrap. [1] [2]

@sauce-base
sauce-base merged commit c6ebe1d into main Jul 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants