Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the Announcements module’s developer experience by reducing logging noise and by wiring an announcement value into Inertia’s shared PageProps via TypeScript module augmentation.
Changes:
- Added an Inertia
PagePropsmodule augmentation to includeannouncement?: Announcement | null. - Switched Announcements initialization logs from
console.logtoconsole.debug. - Removed
patches/types.patch(previously used to patch types).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/js/types/page-props.d.ts | Adds Inertia PageProps augmentation for announcement. |
| resources/js/app.ts | Changes Announcements module logs from log to debug. |
| patches/types.patch | Deletes the old type patch file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small improvement to the logging in the Announcements module by switching from
console.logtoconsole.debugfor initialization messages. Additionally, it updates theUsertype definition to optionally include anannouncementproperty.Type definition update:
Userinterface inresources/js/types/index.d.tsnow optionally includes anannouncementproperty of typeAnnouncement | null, allowing user objects to reference an announcement if present.Logging improvements:
resources/js/app.ts) fromconsole.logtoconsole.debugfor both setup and afterMount lifecycle methods, making debug messages less intrusive in production logs.