Conversation
mtlljm
requested review from
chrismwsas,
katjam-sas,
keeper7kaSAS and
mtlstr-sas
and removed request for
katjam-sas
mtlljm
force-pushed
the
pr-9141-2
branch
2 times, most recently
from
9b1cc12 to
6bad436
Compare
megwu26
left a comment
megwu26
left a comment
There was a problem hiding this comment.
adding some proposed edits
| # Importing the Grafana Dashboard | ||
|
|
||
| Before you import the dashboard, you need to update the `grafana.json` file for your environment: | ||
| Before you import the dashboard, you must update `grafana.json` for your environment because the ESP Server connection URL is different in each cluster. |
There was a problem hiding this comment.
move this lead in sentence to below the prerequisites
| Before you import the dashboard, you must update `grafana.json` for your environment because the ESP Server connection URL is different in each cluster. | ||
|
|
||
| Prerequisites: | ||
| - You must have the SAS Event Stream Processing and Grafana services running in the same cluster. |
There was a problem hiding this comment.
Instead of beginning these sentences with "You must have" just say "The SAS Event Stream Processing and Grafana services are running in the same cluster." but should it be "in" or "on" here?
|
|
||
| Prerequisites: | ||
| - You must have the SAS Event Stream Processing and Grafana services running in the same cluster. | ||
| - You must have the SAS Event Stream Processing Data Source Plug-in for Grafana installed and configured, see [SAS Event Stream Processing Data Source Plug-in for Grafana](https://github.com/sassoftware/grafana-esp-plugin/blob/main/README.md#add-the-sas-event-stream-processing-data-source). |
There was a problem hiding this comment.
Split up this sentence. The second sentence should begin with, "For more information, see link"
| 3. From the drop-down list, select **Import**. | ||
| 4. Click **Upload dashboard JSON file** and select your updated `grafana.json` file. | ||
| 5. Click **Import**. | ||
| 5. Enter a name for the dashboard. |
There was a problem hiding this comment.
This sentence should be, "In the Name field, enter a name for the dashboard."
| 4. Click **Upload dashboard JSON file** and select your updated `grafana.json` file. | ||
| 5. Click **Import**. | ||
| 5. Enter a name for the dashboard. | ||
| 6. Select a folder for the dashboard. |
There was a problem hiding this comment.
This sentence should be, "From the Folder drop-down list, select a folder for the dashboard."
| 5. Enter a name for the dashboard. | ||
| 6. Select a folder for the dashboard. | ||
| 7. If required, change the Unique identifier (UID) by clicking the **Change uid** button and giving the dashboard a unique identifier. | ||
| 8. Select the datasource that you configured with the SAS Event Stream Processing Studio application. |
There was a problem hiding this comment.
This sentence should be, "From the SAS Event Stream Processing Datasource drop-down list, select the datasource that you configured with the SAS Event Stream Processing Studio application."
Add prerequisites Add help on how to find the namespace Remove section about external discovery service Add extra steps on how to complete the import process Signed-off-by: mtlljm <liam.mcgregor@sas.com>
2 participants
Add prerequisites
Add help on how to find the namespace
Remove section about external discovery service
Add extra steps on how to complete the import process