Enable SAS binaries on Linux#63
Open
michaelmayer2 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for offering this, @michaelmayer2! Could someone from the @sassoftware/python-swat team please take a look when you have a moment? |
… doing cross-device file.rename() - Add NUMA to SystemRequirements Signed-off-by: Michael Mayer <michael.mayer@posit.co>
1636a5d to
d42b898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a current version of
R-swaton Linux I getThe PR is fixing this issue by replacing the
file.rename()command inhelper.Rinto afile.copy()anddir.create()function call.Since one of the binaries also depends on NUMA, a
SystemRequirementsfield for NUMA is added as well. Once approved, https://github.com/rstudio/r-system-requirements/ can be updated so that essential system dependencies for the binaries are automatically picked up when run by tools such as r-lib/pak or the same information exposed by Posit Package Manager.Furthermore, when using the SAS binaries, checking
lddin thelibsfolder of the installed R package reveals more missing DLL's that comprise additional SystemRequirements, e.g.Not sure how critical these are for the general functioning of the binaries and the R package.