Skip to content

Use gamma 2.40 for display-referred rec2020#418

Merged
nex3 merged 6 commits into
sass:mainfrom
sass-contrib:rec2020-2.4-gamma
Jul 24, 2026
Merged

Use gamma 2.40 for display-referred rec2020#418
nex3 merged 6 commits into
sass:mainfrom
sass-contrib:rec2020-2.4-gamma

Conversation

@ntkme

@ntkme ntkme commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

@ntkme

ntkme commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

There is a weird ts-jest bug that prevents the test to run on node 20. Otherwise this works fine. Compiled JS code also works fine on node 20 in the js-api-spec test.

Comment thread tsconfig.json Outdated
Comment thread lib/src/value/color.ts Outdated
Comment thread lib/src/value/color.ts Outdated
Comment thread lib/src/value/color.ts Outdated
@nex3 nex3 mentioned this pull request Jan 28, 2026
3 tasks
@ntkme

ntkme commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

@nex3 I fixed other things you pointed out expect the node/typescript/ts-jest compatibility issue. I think one solution is to just compile all test to JS and run plain jest without ts-jest.

@Goodwine What was your other workaround for the color.js 6 typescript import issue? I'm curious because at this point maybe that's actually a better solution.

@Goodwine

Copy link
Copy Markdown
Member

@ntkme I added the following to tsconfig.json:

"paths": {
  "colorjs.io": "node_modules/colorjs.io/...something.../types.d.ts"
}

@ntkme

ntkme commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Basically I used a freshly cloned repo and tried adding the following under "compilerOptions". None of these worked:

    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/src/types.d.ts"
    }
    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/src/index.d.ts"
    }
    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/index.d.ts"
    }

@Goodwine Am I missing something, or maybe you're running an older version of node, typescript, ts-jest, or jest?

@ntkme

ntkme commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

Basically I'm keep hitting this color-js/color.js#707 unless I apply the module and moduleResolution changes suggested in that issue.

@ntkme

ntkme commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

@ntkme
ntkme force-pushed the rec2020-2.4-gamma branch 2 times, most recently from 864fa45 to 0b66e4d Compare January 30, 2026 01:57
@ntkme
ntkme requested a review from nex3 January 30, 2026 01:58
@ntkme
ntkme marked this pull request as ready for review January 30, 2026 01:58
@ntkme
ntkme force-pushed the rec2020-2.4-gamma branch from 0b66e4d to f5e37c8 Compare January 30, 2026 02:01
Comment thread tool/fix-colorjs-types.ts Outdated
@ntkme
ntkme force-pushed the rec2020-2.4-gamma branch from f5e37c8 to 3348fdf Compare May 23, 2026 01:45
@ntkme
ntkme force-pushed the rec2020-2.4-gamma branch 3 times, most recently from 35139f3 to 04e7b17 Compare July 15, 2026 17:20
@ntkme
ntkme requested a review from nex3 July 15, 2026 17:22
dependabot Bot and others added 5 commits July 24, 2026 09:24
Bumps [colorjs.io](https://github.com/color-js/color.js) from 0.5.2 to 0.6.1.
- [Release notes](https://github.com/color-js/color.js/releases)
- [Commits](color-js/color.js@v0.5.2...v0.6.1)

---
updated-dependencies:
- dependency-name: colorjs.io
  dependency-version: 0.6.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ntkme
ntkme force-pushed the rec2020-2.4-gamma branch from 04e7b17 to 449bb54 Compare July 24, 2026 16:32
@nex3
nex3 merged commit de6ceb9 into sass:main Jul 24, 2026
17 checks passed
@ntkme
ntkme deleted the rec2020-2.4-gamma branch July 25, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use gamma 2.40 for rec2020

3 participants