Repository navigation
Extension: pre-roll countdown with cancel and skip - #44
Merged
Merged
Conversation
A 3-2-1 overlay on the recorded page between stream acquisition and the first recorded frame, with skip and cancel controls (buttons or Esc). The gate sits after every grant and picker settles and before the upload session is created, so a cancel tears down with nothing to clean up server-side — it reuses the picker-cancel 'cancelled' status path. The service worker owns the clock and starts capture on its own schedule; the injected overlay (vanilla DOM, serialized function, like the other page surfaces) only displays the count and can end it early via the same raw runtime-message channel as recorderOverlayClosed. If the tab navigates mid-count the recording still starts on time, the overlay self-removes 150ms before zero so it never lands in the first frames, and restricted pages fall back to today's instant start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 3-2-1 pre-roll countdown to the extension recorder: after the user hits Start Recording and every grant/picker settles, a countdown overlays the page with cancel (✕ / Esc) and skip controls before the first frame is captured.
Flow
Design notes
cancelledpath).recorderOverlayClosed.Verification
pnpm typecheck, extension tests 57/57,wxt build(prod + dev) all green.