Skip to content

fix(lints&go-m-m): import order & unused lint & run go-m-m#51

Open
IvoGoman wants to merge 8 commits intomainfrom
fix/lints
Open

fix(lints&go-m-m): import order & unused lint & run go-m-m#51
IvoGoman wants to merge 8 commits intomainfrom
fix/lints

Conversation

@IvoGoman
Copy link
Copy Markdown
Member

No description provided.

@IvoGoman IvoGoman changed the title fix(lints): import order & unused lint suppression fix(lints&go-m-m): import order & unused lint & run go-m-m Dec 1, 2025
uwe-mayer
uwe-mayer previously approved these changes Dec 3, 2025
@IvoGoman IvoGoman dismissed stale reviews from uwe-mayer and abhijith-darshan via 03d0e16 March 9, 2026 08:57
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/disco 0.00% (ø)
github.com/sapcc/disco/api/v1 1.30% (-0.04%) 👎
github.com/sapcc/disco/controllers 0.00% (ø)
github.com/sapcc/disco/hack 0.00% (ø)
github.com/sapcc/disco/pkg/clientutil 0.00% (ø)
github.com/sapcc/disco/pkg/disco 0.00% (ø)
github.com/sapcc/disco/pkg/util 0.00% (ø)
github.com/sapcc/disco/pkg/version 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/disco/api/v1/doc.go 0.00% (ø) 0 0 0
github.com/sapcc/disco/api/v1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/sapcc/disco/api/v1/record_types.go 100.00% (ø) 1 (-1) 1 (-1) 0
github.com/sapcc/disco/api/v1/record_webhook.go 0.00% (ø) 11 (-11) 0 11 (-11)
github.com/sapcc/disco/api/v1/zz_generated.deepcopy.go 0.00% (ø) 65 (-60) 0 65 (-60)
github.com/sapcc/disco/controllers/ingress_shim_controller.go 0.00% (ø) 51 (-50) 0 51 (-50)
github.com/sapcc/disco/controllers/record_controller.go 0.00% (ø) 108 (-120) 0 108 (-120)
github.com/sapcc/disco/controllers/service_shim_controller.go 0.00% (ø) 53 (-50) 0 53 (-50)
github.com/sapcc/disco/controllers/util.go 0.00% (ø) 9 (-10) 0 9 (-10)
github.com/sapcc/disco/hack/kustomize-to-helm.go 0.00% (ø) 0 0 0
github.com/sapcc/disco/main.go 0.00% (ø) 0 0 0
github.com/sapcc/disco/pkg/clientutil/client.go 0.00% (ø) 27 0 27
github.com/sapcc/disco/pkg/clientutil/error.go 0.00% (ø) 3 0 3
github.com/sapcc/disco/pkg/disco/constants.go 0.00% (ø) 0 0 0
github.com/sapcc/disco/pkg/disco/designate.go 0.00% (ø) 72 (-85) 0 72 (-85)
github.com/sapcc/disco/pkg/util/fqdn.go 0.00% (ø) 3 (-3) 0 3 (-3)
github.com/sapcc/disco/pkg/version/version.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/sapcc/disco/api/v1/webhook_suite_test.go
  • github.com/sapcc/disco/controllers/suite_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants