fix: repair devtools build, CLI entry, and test suite - #1
santoshyadavdev merged 1 commit into
Conversation
- use .ts import specifiers in devframe.ts; the package has no build step and Node's type stripping does not remap .js to .ts - enable allowImportingTsExtensions and rewriteRelativeImportExtensions in tsconfig.app.json so ng build still compiles src/server.ts - declare cac, an optional peer of devframe that nothing installs but both bin.mjs call through createCac - provide Router in app.spec.ts and drop the assertion on an h1 that app.html no longer renders
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes add the ChangesDevtools and application updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit hops through imports bright Comment |
|
Hello CodeRabbit good to see you 🐇 |
Four documented commands fail on a clean clone of
main:devtools:build/devtools:dev/extension:build→ERR_MODULE_NOT_FOUND .../rpc/get-routes.jsnode bin.mjs→Cannot find package 'cac'pnpm test→ 2/2 failingFixes:
devframe.tsimports./rpc/*.jsbut the package has no build step, only.tsexists. Node doesn't remap.jsto.ts. Switched to.tsplus two flags intsconfig.app.jsonto keepng buildgreen. Minimal fix; a real build step emitting.jsis the cleaner alternative if you'd rather.cacis an optional peer ofdevframe, so nothing installs it, but bothbin.mjscallcreateCac.Routerprovider, asserts an<h1>thatapp.htmlno longer has.Summary by CodeRabbit
Tests
Chores