Skip to content

fix: repair devtools build, CLI entry, and test suite - #1

Merged
santoshyadavdev merged 1 commit into
santoshyadavdev:mainfrom
erkamyaman:fix/repair-build-cli-and-tests
Sep 21, 2026
Merged

santoshyadavdev merged 1 commit into
santoshyadavdev:mainfrom
erkamyaman:fix/repair-build-cli-and-tests

Conversation

@erkamyaman

@erkamyaman erkamyaman commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Four documented commands fail on a clean clone of main:

  • devtools:build / devtools:dev / extension:buildERR_MODULE_NOT_FOUND .../rpc/get-routes.js
  • node bin.mjsCannot find package 'cac'
  • pnpm test → 2/2 failing

Fixes:

  • devframe.ts imports ./rpc/*.js but the package has no build step, only .ts exists. Node doesn't remap .js to .ts. Switched to .ts plus two flags in tsconfig.app.json to keep ng build green. Minimal fix; a real build step emitting .js is the cleaner alternative if you'd rather.
  • cac is an optional peer of devframe, so nothing installs it, but both bin.mjs call createCac.
  • Spec was the stock scaffold: no Router provider, asserts an <h1> that app.html no longer has.

Summary by CodeRabbit

  • Tests

    • Updated application checks to validate that navigation links correctly point to the home and About pages.
    • Added router configuration coverage to support navigation-related rendering tests.
  • Chores

    • Improved development tooling configuration for more consistent TypeScript module resolution.

- use .ts import specifiers in devframe.ts; the package has no build
  step and Node's type stripping does not remap .js to .ts
- enable allowImportingTsExtensions and rewriteRelativeImportExtensions
  in tsconfig.app.json so ng build still compiles src/server.ts
- declare cac, an optional peer of devframe that nothing installs but
  both bin.mjs call through createCac
- provide Router in app.spec.ts and drop the assertion on an h1 that
  app.html no longer renders
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 955d9faf-a2b0-4825-a390-68d936ee3131

📥 Commits

Reviewing files that changed from the base of the PR and between 44a7e20 and c940b08.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • packages/ng-devtools/package.json
  • packages/ng-devtools/src/devframe.ts
  • src/app/app.spec.ts
  • tsconfig.app.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes add the cac runtime dependency, update TypeScript import resolution, and revise the application test to provide a router and verify navigation link URLs.

Changes

Devtools and application updates

Layer / File(s) Summary
Module resolution and package configuration
packages/ng-devtools/package.json, packages/ng-devtools/src/devframe.ts, tsconfig.app.json
The package adds cac. Devtools imports use .ts extensions. The application TypeScript configuration enables and rewrites TypeScript extension imports.
Router link test coverage
src/app/app.spec.ts
The test provides an empty router and checks that navigation links expose / and /about hrefs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: santoshyadavdev

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: repairing the DevTools build, CLI entry, and test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

A rabbit hops through imports bright
.ts paths now point just right
Links to home and about gleam
Routers guide the testing dream
CAC joins the devtools team

Comment @coderabbitai help to get the list of available commands.

@erkamyaman

Copy link
Copy Markdown
Contributor Author

Hello CodeRabbit good to see you 🐇

@santoshyadavdev
santoshyadavdev merged commit 077fd6a into santoshyadavdev:main Sep 21, 2026
1 check passed
@erkamyaman
erkamyaman deleted the fix/repair-build-cli-and-tests branch September 21, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants