Open
Conversation
Added a `const std::string& step` parameter to the RDMs save and load functions. This affects the file names used allowing to store the RDMs for the variational and perturbative steps in different files.
This updates the statements employing save/load rdm functions in SHCI.cpp and SHCIbasics.cpp. This fixes issues when using DoRDMs, DoOneRDM, DoSpinOneRDM or DoSpinRDM flags for a deterministic perturbation SHCI computation. The correct file now is loaded for each step and the RDMs for each step are saved in different files.
Author
|
Here is an example of an affected input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds step-awareness to the SHCI RDM save/load functions, enabling proper handling of "variational" and "perturbative" stages in the workflow.
Problem
Previously:
Fixes Introduced
This PR modifies the RDM handling logic to:
steplabel ("variational" or "perturbative") to both saving and loading paths.prefix/root1-root2-RDMName-step.ext, wherestepindicates the calculation phase (e.g.,variationalorperturbative), andextspecifies the file extension (eithertxtorbkp).Missing