Skip to content

fix(ci): IMP-08 secret scan fails PR on keys/.env in tree or diff - #8

Merged
sanjaymaverick-cmd merged 1 commit into
mainfrom
fix/imp-08-secret-scan
Sep 14, 2026
Merged

sanjaymaverick-cmd merged 1 commit into
mainfrom
fix/imp-08-secret-scan

Conversation

@sanjaymaverick-cmd

Copy link
Copy Markdown
Owner

Summary

  • npm run secret-scan / scripts/secret-scan.mjs --ci — tracked tree + diff vs main
  • Wired into npm test via scripts/secret-scan.test.mjs
  • GitHub Action .github/workflows/secret-scan.yml on PR + push to main
  • Blocks .env*, key material, non-placeholder broker/API assigns; does not stage secrets

Ticket

IMP-08 | Lane 1 Honesty closer | HEAD before 3950070

Test plan

  • node --test scripts/secret-scan.test.mjs
  • node scripts/secret-scan.mjs --ci
  • CI green on this PR

Lane 1 closes when merged. Next: IMP-09 promotion verdict strip.

Add scripts/secret-scan.mjs (tree + diff), wire npm run secret-scan and
tests, and a GitHub Action so secrets stop the PR. No secrets committed.
@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 6 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

PR taxonomy review recommended (neutral)

Detected 3 PR taxonomy bucket(s): Security Evidence, Install Manifest Integrity, CI/CD Recommendation.

Scanned 6 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

  • 2 security-sensitive path(s) changed

Paths:

  • .github/workflows/secret-scan.yml
  • scripts/secret-scan.mjs

Install Manifest Integrity

Install manifests, plugin metadata, and shipped skills should stay synchronized with user-facing setup guidance.

Signals:

  • 1 install or manifest path(s) changed

Paths:

  • package.json

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • CI workflow changes may ship without failure-mode evidence
  • Dependency or CI drift could surface after merge
  • 3 CI or workflow path(s) changed

Paths:

  • .github/workflows/secret-scan.yml
  • package.json
  • scripts/secret-scan.test.mjs
  • scripts/secret-scan.mjs

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

Reference set readiness gaps detected (neutral)

Reference evidence present for 1/7 areas (14%) across 6 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Present .github/workflows/secret-scan.yml, scripts/secret-scan.mjs, scripts/secret-scan.test.mjs
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 6 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / PR Config Audit

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

  • .github/workflows/secret-scan.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Sep 14, 2026

Copy link
Copy Markdown

ECC Tools / PR Harness Audit

Commit: 82a14ab6e9f45635ffdea440437372e9ef7c98ca

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

  • .github/workflows/secret-scan.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@sanjaymaverick-cmd
sanjaymaverick-cmd merged commit 83b8aee into main Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant