Skip to content

fix: distinguish unassessed job scores - #22

Merged
sangowu merged 1 commit into
mainfrom
codex/fix-null-score-badge
Aug 11, 2026
Merged

sangowu merged 1 commit into
mainfrom
codex/fix-null-score-badge

Conversation

@sangowu

@sangowu sangowu commented Aug 11, 2026

Copy link
Copy Markdown
Owner

What changed

  • render unassessed null/undefined scores as a gray em dash
  • preserve numeric zero as a real red 0 score
  • add a regression test and update the changelog and bug-fix log

Root cause

scoreBadge() converted the API's score: null with Number(null), which JavaScript evaluates as 0. This made jobs without a current-CV match_score look like genuine zero-score matches.

Validation

  • 248 passed
  • Ruff passed
  • Python compileall passed
  • frontend syntax check passed
  • direct Node behavior check confirmed null and zero badges remain distinct
  • live / response contains the corrected frontend logic

@sangowu
sangowu merged commit 559ec45 into main Aug 11, 2026
2 checks passed
@sangowu
sangowu deleted the codex/fix-null-score-badge branch August 11, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant