Allow static standalone build - #44
Merged
aj463 merged 4 commits intoAug 20, 2026
Merged
Conversation
…g cmake to honor BUILD_SHARED_LIBS setting. Signed-off-by: Nate Roberts <nvrober@sandia.gov>
Signed-off-by: Nate Roberts <nvrober@sandia.gov>
Signed-off-by: Nate Roberts <nvrober@sandia.gov>
…duplicate symbol errors. Signed-off-by: Nate Roberts <nvrober@sandia.gov>
GrahamBenHarper
approved these changes
Aug 18, 2026
GrahamBenHarper
left a comment
GrahamBenHarper
left a comment
Collaborator
There was a problem hiding this comment.
I double-checked it on my end, and it looks like it works. Thanks @CamelliaDPG!
Contributor
Author
|
Thanks, @GrahamBenHarper! |
Collaborator
|
@aj463 does this look good to you as well? |
Collaborator
|
Looks good to me too! We appreciate the help with this |
aj463
self-requested a review
August 20, 2026 07:44
aj463
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For standalone ROL build, drop the hard-coded
SHAREDfrom theadd_libraryline. Add a CMake optionROL_ENABLE_TEUCHOS_LITE_OBJECTSgoverning whether the Teuchos "Lite" libraries are added with ROL.These features allow downstream projects to build against standalone ROL while also linking against the full Teuchos libraries, and to do so in a static build.
In particular, this is useful to FuSED OED.