Repository navigation
Cvxpy import fix. Double argument fix within rattlesnake control laws. - #25
Merged
Merged
Conversation
…. Fixed a typo in the rattlesnake control laws file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with cvxpy not playing well with PyQt5 when they both import the same .dll at some point within their python import statements. cvxpy must be imported first in the forcefinder init.py file for this to not crash the kernel. This fix was verified with forcefinder import statements and running the rattlesnake control laws.
This patch also fixes a typo in the rattlesnake control law where update_header was provided as a duplicate argument.