🚧 Retire FileValidator#1188
Draft
laritakr wants to merge 1 commit into
Draft
Conversation
FileValidator produced aggregate file fields (`missingFiles`, `fileReferences`, `foundFiles`, `zipIncluded`) on the validate JSON which drove a dedicated `file_references` UI accordion. This is now functionally redundant, as it has been replaced by the new per-row CsvRow::FileReference that produces the same information with row attribution and path-aware comparison. With this commit, we drop FileValidator and the four aggregate fields. Missing files now appear in the `row_level_warnings` accordion as warnings. The "files referenced but no zip" case becomes a notice shown via the `notices` accordion. This also requires an update in Demo Mode. The JSON scenarios and the DEMO_MODE=true runtime mock both emit the new shape. Consolidated the duplicated spec demo_scenarios.json to the canonical copy under lib/. Obsolete locale keys are removedacross all seven supported languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the basename-only
Bulkrax::FileValidatorwith a path-aware per-rowCsvRow::FileReferencevalidator, dropping the four legacy aggregate response fields and routing missing-file warnings through the standard row-warnings accordion.