Repository navigation
fix(ios): show the poster on a detail opened from the What to watch widget - #181
Merged
Merged
Conversation
…idget The widget deep link carries no poster, so the hero kept its placeholder. When the caller passes none, fetch the library item's poster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a title on the What to watch widget opens its detail through a
rawkoon://medialink that carries no poster, and the route was built withposterUrl: nil. The detail hero only used the caller's poster, so it stayed on the gradient placeholder while the backdrop (from TMDB details) loaded.MediaDetailViewnow resolves the poster as: caller's poster → admin library item's poster → alibraryItem(id:)fetch when neither exists. The hero and the watchlist/request actions use the resolved value.Fixed app-side rather than adding a poster to the widget link, so snapshots already written by older builds are covered too.
Verified on macOS: l10n + env-inject checks, swiftformat lint clean, simulator
xcodebuild buildsucceeded.