Repository navigation
Conversation
Author
|
I have now tested this on Windows against af507cc (the commit that libtem is pointing at today). Closing with unsaved changes asks, without them it closes immediately, minimised-and-closed restores the window first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, closing the window lets
DefWindowProcdestroy it, and the main loop then ends onWM_QUITbeforeiterate()is called, so an application can't ask anything (e.g. about unsaved changes). The SDL2 backend instead setsdone = truebeforeiterate(done), which the application can reset.This handles
WM_CLOSEinWndProc(sets a flag instead of destroying the window) and passes it to the application asdone = truebeforeiterate(done), matching SDL2. A minimised window is restored first so the frame actually runs. The window is still destroyed in the existing cleanup after the loop.For applications that ignore
done, closing behaves as before, except thatiterate()runs one more frame withdone == true(as with SDL2).