Skip to content
This repository was archived by the owner on Nov 7, 2023. It is now read-only.

Ts conversion#758

Closed
Luiz-Monad wants to merge 2 commits into
salman0ansari:mainfrom
Luiz-Monad:ts_conversion
Closed

Ts conversion#758
Luiz-Monad wants to merge 2 commits into
salman0ansari:mainfrom
Luiz-Monad:ts_conversion

Conversation

@Luiz-Monad

Copy link
Copy Markdown

Related to pull request #486

I was commissioned to create a backend middleware for a frontend using this library, but I cannot use Javascript because its too unproductive, so I ended up doing this task by mistake (figuring out types is literally all fun and games, I did it on my weekend)

I hope nothing got broke as this project has not much in tests.

@salman0ansari

Copy link
Copy Markdown
Owner

Nah it's not related to #486
I am rewriting whole project in ts not adding types to existing code.

Adding ts doesn't make any sense to existing code because it's full of bug.

@salman0ansari

Copy link
Copy Markdown
Owner

i can push this PR to a different branch but sorry I can't push it to main.

@Luiz-Monad

Luiz-Monad commented Aug 1, 2023

Copy link
Copy Markdown
Author

I understand this is a breaking change in SemVer. But its a way of removing the bugs. You don't have any tests either, a rewrite is probably required.
That's what forks are for.

This is a temporary solution for me, I'm probably going to rewrite the entire thing in C# as I don't like nodejs that much.

You can leave it in another branch for anyone that might need it for some reason, I only pushed the PR because the license requires me to (its GPL after all).

I wish you the best of luck in your rewrite.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants