fix: resolve opensource review findings - #107
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba62cb5744
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Why
The review found several independent paths where stale asynchronous work or incomplete identity checks could overwrite newer state, revive deleted data, lose practice progress, misroute suite completions, or render an outdated UI. Other defects came from legacy migration assumptions, unsafe imported markup, generated-data mismatches, and test files that were not actually exercised by the configured unit-test command.
The changes preserve the project's existing IndexedDB-first data contract, suite message protocol, generated bundle workflow, and graceful degradation rules while adding explicit conflict, ownership, identity, and latest-wins checks.
User and developer impact
Users get safer restore/reset behavior, durable interrupted sessions, reliable suite and replay navigation, correct vocabulary scheduling, safer imports, and consistent behavior under rapid navigation or multi-window use. Developers get regressions for the repaired edge cases, complete test discovery, more deterministic E2E execution, and bundle drift detection.
Validation
git diff --check: passedba62cb574488b878aa766ba25bd60a9d152eab33: verified OpenPGP good signatureKnown non-blocking debt