Skip to content

Change the default value of atk, def to Empty (-1) #21

Merged
salix5 merged 4 commits into
masterfrom
form-default
Jun 18, 2026
Merged

Change the default value of atk, def to Empty (-1) #21
salix5 merged 4 commits into
masterfrom
form-default

Conversation

@salix5

@salix5 salix5 commented Jun 18, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The UI currently displays unknown ATK/DEF (-2) as “-2” instead of “?”, and the updated readmes don’t fully document the new blank/0 ATK/DEF search semantics.

Pull request overview

This PR updates DataEditorX to treat ATK/DEF default values as “empty” (-1) in the editor, and adjusts search/save behavior so blank ATK/DEF inputs are interpreted as “no filter” while still supporting unknown (-2 / ?) values.

Changes:

  • Introduces Card.Empty and changes Card’s default atk/def initialization to -1.
  • Updates the editor UI to display blank ATK/DEF and ID/alias when values are “empty”/zero, and updates parsing so blank ATK/DEF maps to -1.
  • Updates database parameter binding and search condition building to account for the new “empty” sentinel behavior.
File summaries
File Description
DataEditorX/readme.txt Updates Chinese documentation for ATK/DEF search behavior (currently incomplete for new semantics).
DataEditorX/readme_english.txt Updates English documentation for card search (currently missing key cases; also contains a typo).
DataEditorX/DataEditForm.Designer.cs Removes default "0" text values from ATK/DEF/ID/alias textboxes.
DataEditorX/DataEditForm.cs Implements new empty/unknown parsing and blank rendering for ATK/DEF and IDs; improves binding update for strs.
DataEditorX/Core/Database.cs Maps -1 to 0 on write; updates ATK/DEF query conditions to treat -1 as “no filter”.
DataEditorX/Core/Card.cs Adds Card.Empty and changes default atk/def initialization to -1.

Copilot's findings

Files not reviewed (1)

  • DataEditorX/DataEditForm.Designer.cs: Generated file
  • Files reviewed: 5/6 changed files
  • Comments generated: 5

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DataEditorX/DataEditForm.cs
Comment thread DataEditorX/DataEditForm.cs
Comment thread DataEditorX/readme.txt
Comment thread DataEditorX/readme_english.txt Outdated
If there is a "0", input"-1"or"."
If there is a "?", input"-2"or"?"
4. Search by card name:
1. You can search card with card name/effect/Attribute/Types/Level(racnk)/effect type/card id
Comment thread DataEditorX/readme_english.txt
@salix5 salix5 merged commit b757000 into master Jun 18, 2026
5 checks passed
@salix5 salix5 deleted the form-default branch June 18, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants