Remove save as MSE #20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the “Save As MSE” (Magic Set Editor) export workflow from DataEditorX, including the related UI, background task handling, configuration keys, and documentation references.
Changes:
- Removed MSE export menu items and corresponding task execution paths.
- Deleted MSE-related config entries and language strings, and updated docs to drop MSE references.
- Adjusted image output path handling by introducing an
Imagespath constant and updating the crop output location.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes MSE export/import from the feature list. |
| DataEditorX/readme.txt | Removes MSE documentation and updates image setting description. |
| DataEditorX/readme_english.txt | Removes MSE-related documentation sections. |
| DataEditorX/MainForm.cs | Updates comment to remove mention of MSE data. |
| DataEditorX/DataEditForm.Designer.cs | Removes the MSE menu and event hook-ups from the UI. |
| DataEditorX/DataEditForm.cs | Removes MSE task completion handling and MSE export actions. |
| DataEditorX/data/language_english.txt | Removes MSE menu labels/messages and neutralizes related message IDs. |
| DataEditorX/data/language_chinese.txt | Removes MSE menu labels/messages and neutralizes related message IDs. |
| DataEditorX/Core/TaskHelper.cs | Removes MSE helper/export logic; updates crop output path. |
| DataEditorX/Core/MyTask.cs | Removes the SaveAsMSE task enum entry. |
| DataEditorX/Config/MyConfig.cs | Adds PATH_IMAGES constant. |
| DataEditorX/app.config | Removes MSE-related settings keys. |
Files not reviewed (1)
- DataEditorX/DataEditForm.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.