Skip to content

Migrate registerTool to presentation.label for SDK 0.4.16+ #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrBoebel wants to merge 1 commit into from
Closed

Migrate registerTool to presentation.label for SDK 0.4.16+ #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ import {

const PLUGIN_ID = "advisor";
const ADVISOR_TOOL = "advisor_review";

// Spread rather than inlined: `presentation` replaced `experimental_statusLabels`
// in SDK 0.4.16, but the vendored 0.4.2 declarations in types/ do not describe it
// yet, so an inline literal trips the excess-property check. See the PR notes on
// `bb plugin migrate` for the follow-up that makes this typed.
const ADVISOR_TOOL_PRESENTATION = {
presentation: {
label: { pending: "Consulting advisor", completed: "Consulted advisor" },
},
};
const ADVISOR_TITLE_PREFIX = "Advisor · ";
/**
* Permission modes the reviewer will accept, least privileged first. The mode
Expand Down Expand Up @@ -1585,10 +1595,7 @@ export default async function plugin(bb: BbPluginApi) {
"Run an independent review-only model pass on this thread and return concrete issues before finalizing.",
instructions:
"For substantial coding work, call advisor_review exactly once after implementation and verification but before the final answer. Address concern/blocker feedback before completing.",
experimental_statusLabels: {
pending: "Consulting advisor",
completed: "Consulted advisor",
},
...ADVISOR_TOOL_PRESENTATION,
parameters: z.object({
focus: z
.string()
Expand Down