Verify request lifecycles and document feature support for v2.6.0 - #13
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (29)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e53579cb5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Problem and change
Concurrent GC requests could consume unrelated notifications, miss synchronous responses, or leave listeners/timers behind after timeout or disconnect. This centralizes request lifecycles, serializes ambiguous correlation keys, quarantines uncertain results without retries, and adds cancellation/disposal with structured errors. It also fixes inventory duplicate/reordering behavior, profile dispatch, numeric inspect inputs, absent wear, and malformed nested protobuf handling.
A reusable fake Steam transport and independently encoded fixtures exercise real bytes, dispatch, handlers, events, callbacks, and Promises. A shared deterministic corpus covers both inspection libraries. Schema-derived event types and compile-time examples replace unknown response types. FEATURE_SUPPORT.md separates payload, decoder, lifecycle, and live evidence; the opt-in authenticated runner defaults to a read and requires individual mutation selection, designated items, and observable inventory postconditions.
Prepares node-cs2 2.6.0 using the existing npm/manual release process. Existing public call signatures remain supported. See the migration notes for lifetime quarantine after sent failures and historical success-only inspect callbacks. Live Steam/GC behavior remains unverified; several notification associations are explicitly documented hypotheses.
Validation