Adds flush-cache and several minor changes#6
Open
luislobo wants to merge 4 commits into
Open
Conversation
luislobo
commented
Dec 14, 2016
luislobo
commented
Contributor
- Adds flush-cache
- Removes // placeholders
- Fixes references to some URLs
- Made all tests use database Update pre-connection error catching to adjust for change in redis 2.8.0 #15
- Replaced use of destroyKeys with flushCache on before and after tests
- Commented what options can be added to a redis connection string
- Moved the example in README to a separate file in an examples folder.
Adds flush-cache Removes // placeholders Fixes references to some URLs Made all tests use database sailshq#15 Replaced use of destroyKeys with flushCache on before and after tests Commented what options can be added to a redis connection string Moved the example in README to a separate file in an examples folder.
luislobo
commented
Dec 22, 2016
luislobo
left a comment
luislobo
left a comment
Contributor
Author
There was a problem hiding this comment.
@mikermcneil just in case you missed this one
Member
|
@luislobo slowly catching up on everything else, hope to get a chance to look at this soon |
Contributor
Author
|
@mikermcneil np, let me know if you need some help around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.