Skip to content

feat: add boolean bindings support for SQLite queries #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DominusKelvin merged 1 commit into from
Jan 15, 2026
Merged

feat: add boolean bindings support for SQLite queries #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions lib/private/machines/private/build-sqlite-where-clause.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ module.exports = function buildSqliteWhereClause(whereClause, WLModel, meta) {
return { clause: '', bindings: [] }
}

// Helper to convert values for SQLite binding
// SQLite/better-sqlite3 only accepts: numbers, strings, bigints, buffers, and null
// Booleans must be converted to integers (0/1)
function toSqliteValue(val) {
if (typeof val === 'boolean') {
return val ? 1 : 0
}
return val
}

const bindings = []

// Recursively build WHERE clause
Expand Down Expand Up @@ -77,44 +87,44 @@ module.exports = function buildSqliteWhereClause(whereClause, WLModel, meta) {
if (Array.isArray(operatorValue) && operatorValue.length > 0) {
const placeholders = operatorValue.map(() => '?').join(', ')
conditions.push(`${columnName} IN (${placeholders})`)
bindings.push(...operatorValue)
bindings.push(...operatorValue.map(toSqliteValue))
}
break
case 'nin':
if (Array.isArray(operatorValue) && operatorValue.length > 0) {
const placeholders = operatorValue.map(() => '?').join(', ')
conditions.push(`${columnName} NOT IN (${placeholders})`)
bindings.push(...operatorValue)
bindings.push(...operatorValue.map(toSqliteValue))
}
break
case '>':
conditions.push(`${columnName} > ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case '>=':
conditions.push(`${columnName} >= ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case '<':
conditions.push(`${columnName} < ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case '<=':
conditions.push(`${columnName} <= ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case '!=':
case 'ne':
conditions.push(`${columnName} != ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case 'like':
if (meta && meta.makeLikeModifierCaseInsensitive === true) {
conditions.push(`LOWER(${columnName}) LIKE LOWER(?)`)
} else {
conditions.push(`${columnName} LIKE ?`)
}
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
break
case 'contains':
conditions.push(`${columnName} LIKE ?`)
Expand All @@ -130,13 +140,13 @@ module.exports = function buildSqliteWhereClause(whereClause, WLModel, meta) {
break
default:
conditions.push(`${columnName} = ?`)
bindings.push(operatorValue)
bindings.push(toSqliteValue(operatorValue))
}
})
} else {
// Simple equality
conditions.push(`${columnName} = ?`)
bindings.push(value)
bindings.push(toSqliteValue(value))
}
})

Expand Down
Loading