Open
Conversation
saik0
requested changes
Apr 11, 2026
| /** | ||
| * Converts a GiphRsError to a standard Kotlin Exception | ||
| */ | ||
| fun GiphRsError.toException(): Exception { |
Owner
There was a problem hiding this comment.
This gets translated by UniFFI to GiphRsException which is an Exception
| @@ -53,7 +54,7 @@ impl RustViewModel { | |||
| } | |||
|
|
|||
| pub fn has_error(&self) -> bool { | |||
Owner
There was a problem hiding this comment.
This should follow the pattern of having an accessor and a polling function for changes it should be updated to return Option<GiphRsError>
However, this introduces an issue as a stream's terminal state is indicated by a None value. We could get around it by adding a GiphRsError.None enum value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate errors from Rust to Swift via GiphRSError