Added Profiling System#41
Conversation
|
same code shouldn't be saved multiple times. Plus, I can't view the saved code. |
|
@mananpal1997 I'll fix so that same code is not saved multiple times and for viewing the saved code, open the profile tab and then open the links in new tab for now.(anchor tags are not working correctly) |
|
@sahil865gupta Since this is a breaking change, can you please host this application as a test heroku app so that we can check the feature extensively? |
|
@sahil865gupta Thanks for your patience! This looks really good. However I have some minor suggestions -
|
|
I'll fix these issues asap. |
|
|
||
| $("#title-save").click(function(){ | ||
|
|
||
| // if a run request is ongoing |
There was a problem hiding this comment.
Since all the code in this callback function is repeated, can you put it into a separate function and call it everywhere this code is repeated?
|
@sahil865gupta do you need more time for this? |
|
I was not able to do this because of exams but i'll do it today. |
|
@sahildua2305 Does this seems ok now? |
|
@sahil865gupta did you work on these as well? |
|
Yeah i have done that too. I updated the code at https://test-hackide.herokuapp.com/ |
|
Hi @sahil865gupta, long time! :D I wonder if you'd be up to try to merge this and ship this feature. |
Fixes #39