Theses cleanup#166
Conversation
| type = {phdthesis}, | ||
| @phdthesis{Deka2005, | ||
| author = {Deka, Lipika}, | ||
| school = {University of California, Davis}, |
There was a problem hiding this comment.
I changed institution to school as the former is not a supported field type for thesis in bibtex and the latter is.
Also, all the theses use location for usually the department name. Per bibtex address should be used instead and isn't even needed.
From the bibtex docs:
For theses, van Leunen recommends not giving the school’s department
after the name of the degree, since schools, not departments, issue degrees.
If you really think that giving the department information will help the
reader find the thesis, put that information in the address field.
Right now my changes have this behave inconsistently. Before I fix it, do we want to include departments under address (I don't see a reason to, this would mostly just be "Department of Mathematics" in various languages anyway)? Just the country? Leave the address blank? @haraldschilly thoughts?
There was a problem hiding this comment.
Hmm, I don't have any "thoughts". This is really old, and I don't think MUPAD even shows up on the website. (I don't know why, there is certainly a story behind collecting those references but not listing them).
Overall, if you're motivated to streamline this according to the correct conventions, I'm on your side. I also saw you tweak the ancient python script someone wrote a long time ago as well. So, this is clearly nice.
About lines like:
htmlstr = "".join([htmlstr, f'{thesis.get("type", "Masters thesis")}, '])Here, my thought is, either assemble all strings of the citation in an array and run e..g ", ".join( ... ) once, for all of them, or just do htmlstr += f'{thesis.get("type", "Masters thesis")}, '. As it is, it is a bit weird...
Either way, the main goal is that this test passes (script runs) and the resulting html snippet is useable for the website 😄
There was a problem hiding this comment.
regarding mupad, this is the only commit I found sagemath/website@b1d0832
There was a problem hiding this comment.
I don't think MUPAD even shows up on the website. (I don't know why, there is certainly a story behind collecting those references but not listing them).
On https://www.sagemath.org/library-publications.html there is "See also the list of publications citing SageMath-Combinat." which contains "SageMath-Combinat is the reincarnation in SageMath of MuPAD-Combinat; see the list of publications citing the latter."
So you can navigate to https://www.sagemath.org/library-publications-mupad.html it's just somewhat hidden.
|
Cleans up the theses as best as I can, and also the code to process them. From now on, a Masters thesis should use the If a graduate-level thesis is not technically a "Masters thesis" or "PhD thesis" then use whichever is closer and specify the type with the "type" tag. For example, |
|
ok, I see, sounds good to me 😄 |
|
ok. published this. should be live in a few minutes … |
|
@vincentmacri weird. it fails when actually building the page here: https://github.com/sagemath/website/actions/runs/18137753689/job/51620794414#step:5:62 I don't understand. Is this an older (more stupid) python? I hope the quick fix is to set a variable to the partial string, and then assemble it there. … or just change the whole construct to |
Seems so: https://stackoverflow.com/questions/78388333/nested-quotes-in-f-string-with-python-3-12-vs-older-versions https://docs.python.org/3.12/whatsnew/3.12.html#pep-701-syntactic-formalization-of-f-strings |
|
Should be fixed in #167 |
|
YES, that's it! |
Fixes #98 and other cleanup and formatting issues for theses. There is probably more that can be fixed but I don't want to spend a bunch of time fixing
.bibentries.