governance: make ProofPath capability canonicality explicit (FCRP-SELF-005) - #220
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR adds a capability promotion contract, a 26-capability manifest, and an FCRP-SELF-005 governance record. It adds fail-closed validation, regression tests, and a GitHub Actions workflow that enforces manifest and canonicality checks. ChangesCapability manifest lifecycle
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions as GitHub Actions
participant Validator as validate_capability_manifest.py
participant Manifest as capability-manifest.v0.1.json
participant RegressionTests as test_capability_manifest.py
GitHubActions->>Validator: Validate manifest
Validator->>Manifest: Load and check manifest
Validator-->>GitHubActions: Return validation result
GitHubActions->>RegressionTests: Run regression tests
RegressionTests->>Validator: Test valid and invalid manifests
Validator-->>RegressionTests: Return validation outcomes
GitHubActions->>Manifest: Assert FCRP-SELF-005 bindings and capability references
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
safal207
marked this pull request as ready for review
August 14, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the repository-level refactor identified by FCRP-SELF-005: Canonical Reality Drift.
The audit found that ProofPath has two different kinds of reality at once:
maincontinues to evolve and already contains promoted capabilities such as SCIG v0.1 (feat: SAFE Causal Incident Graph v0.1 #219);main.The first meaningful divergence is PR #193 (PoCI v0.1 contract). It is the earliest open capability in the current stack, is based directly on
main, and later capabilities build transitively on it while it remains unmerged.This PR does not solve that by mass-merging the stack. It adds an explicit promotion/canonicality contract so branch architecture can no longer be mistaken for ambient ProofPath capability.
Added
governance/capability-manifest.v0.1.jsonCANONICAL / PROPOSED / EXPERIMENTAL / SUPERSEDED / ARCHIVEDlifecycle states;docs/CAPABILITY_PROMOTION_CONTRACT.mdscripts/validate_capability_manifest.pytests/test_capability_manifest.pygovernance/fcrp-self-005.json.github/workflows/proofpath-capability-manifest.ymlCurrent audited state
At audit time:
The manifest records the full audited branch dependency graph rather than treating a successful branch CI run as promotion.
Consumer invariant
A downstream repository may depend by default only on:
A
PROPOSEDorEXPERIMENTALcapability requires explicit opt-in plus exact PR/head SHA and must not be described as an ambientmaincapability.The validator fails closed if:
FCRP result
Boundary
This PR does not promote, merge, close, retarget, or rewrite any existing capability PR. It only establishes the contract needed to evaluate those transitions safely and then repeat the same repository-integrity audit across the NEO REZONANS stack.
Summary by CodeRabbit
New Features
Validation & Reliability