Fix simplify crash, add zoo hint, expand linalg subcommands#26
Merged
Conversation
Bug fixes: - Guard simplify() with isinstance(parsed, sympy.Basic) to prevent Atom._eval_simplify() crash when a bare name like S or d is evaluated (closes #16) - Add post-result hint when value is zoo (complex infinity), so users understand division-by-zero results rather than seeing an opaque symbol Linalg expansion (v0.3.0): - Add linalg det/inv/rank/eig/nullspace subcommands to _evaluate_linalg_alias - Update :linalg help text and README reference table with new subcommands - Update diagnostics hint to list all available linalg subcommands - Add smoke install check for new linalg subcommand in CI Coverage: 97% (+1.5pp), cli.py 98% (+5pp) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simplify()withisinstance(parsed, sympy.Basic)— preventsAtom._eval_simplify()crash when a bare helper name likeSordis evaluatedhint: zoo = complex infinity; the expression is undefined (e.g. division by zero)when result iszoo, so users aren't left with an opaque symbollinalg det,inv,rank,eig,nullspacesubcommands alongside existingsolveandrref; update:linalghelp, README reference table, and diagnostics hint textlinalg detsmoke install checkTest plan
uv run --group dev pytest)cli.pyat 98% (+5pp)test_cli.pytest_cli_unit.pycovering_evaluate_linalg_aliasbranches and_execute_expressionzoo hint path🤖 Generated with Claude Code