test message#4
Open
sabbir-47 wants to merge 2 commits into
Open
Conversation
MarSik
reviewed
Mar 14, 2024
MarSik
reviewed
Mar 14, 2024
|
Conceptually this is exactly what we want I think. You might need to protect it so it works properly on non-Intels (returning empty string or disable or whatever). |
Owner
Author
Thank you @MarSik for your feedback, i will enhance it based on your suggestion. |
Signed-off-by: Sabbir Hasan <sahasan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test changes