Skip to content

Introduce clang-format and clang-tidy#16

Open
marcluque wants to merge 4 commits into
s3mme:mainfrom
marcluque:clang-format
Open

Introduce clang-format and clang-tidy#16
marcluque wants to merge 4 commits into
s3mme:mainfrom
marcluque:clang-format

Conversation

@marcluque
Copy link
Copy Markdown
Contributor

@marcluque marcluque commented Oct 13, 2022

This is an initial proposal for a .clang-format and .clang-tidy setup. 739e3e5 and 25eea57 respectively show clang-format and clang-tidy changes.

I would suggest not looking at the changes, since github does not display everything correctly. Instead looking at the source directly should be better.

Some major points:

  • use 4 spaces
  • right align pointer *
  • Break after certain line width

This addresses #13.

@s3mme s3mme force-pushed the main branch 7 times, most recently from b80603f to a67a03f Compare October 13, 2022 18:59
@marcluque marcluque marked this pull request as draft October 14, 2022 12:06
@marcluque marcluque marked this pull request as ready for review October 14, 2022 12:06
Copy link
Copy Markdown
Contributor

@mormod mormod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this, so the resulting .clang-format and .clang-tidy files can be used in Benzammour/yobemag

Comment thread src/cpu.h
Comment thread src/logging.h Outdated
Comment thread src/sound.c
Comment thread src/sound.c
Comment thread src/timer.c
Comment thread src/sound.c
Comment thread .clang-format Outdated
Co-authored-by: Moritz Hüllmann <20692341+mormod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants