Repository navigation
[codex] Prevent lost CAN transport shutdown wakeups - #43
Merged
Merged
Conversation
s2015-turtle
marked this pull request as ready for review
October 1, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rolling CI for #42 exposed an existing hang in
CanTransport.StopsWhileBatchesAreBeingProduced:stop.wait_for(5s)timed out, followed by the overall test timeout.stop()changedrunning_and notified the condition variable withoutpending_mutex_. The worker could evaluate the predicate as false, miss the shutdown notification before entering its wait, and then sleep indefinitely while stop joined it.Fix
Validation
This is distinct from #31's permanently blocked publisher case and does not claim bounded shutdown for a sink that never returns.