Skip to content

Import Urls from Burp Suite - Feature#17

Open
0xrishabh wants to merge 7 commits into
s0md3v:masterfrom
0xrishabh:ImportBurpLogs
Open

Import Urls from Burp Suite - Feature#17
0xrishabh wants to merge 7 commits into
s0md3v:masterfrom
0xrishabh:ImportBurpLogs

Conversation

@0xrishabh
Copy link
Copy Markdown

No description provided.

@0xrishabh
Copy link
Copy Markdown
Author

Import URLs from Burp suite logs - Feature

@0xrishabh 0xrishabh requested a review from s0md3v January 17, 2020 13:09
Comment thread core/utils.py Outdated
import json
import tempfile

import csv
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it before "import tld"

Comment thread core/utils.py Outdated
url = line['Host']+line['Path']
if url not in urls:
urls.append(url)
return urls No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline

Comment thread corsy.py Outdated
parser.add_argument('-t', help='thread count', dest='threads', type=int, default=2)
parser.add_argument('-d', help='request delay', dest='delay', type=float, default=0)
parser.add_argument('-q', help='don\'t print help tips', dest='quiet', action='store_true')
parser.add_argument('-f', help='import from burp logs', dest='file')
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This argument doesn't accept any additional value, hence add action='store_true' to make it Boolean.
  2. I think -b is a better name for it and the dest value can be burp_file or burp_log.
  3. The help text should be treat input file as Burp Suite logs
  4. Please change the position of this line according to it's length.

Comment thread corsy.py Outdated
if inp_file:
urls = create_url_list(target, inp_file)
elif log_file:
urls = url_from_logs(log_file)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_url_list must be executed even if there's no input file added by the user. Hence, the code here should be:

if log_file:
    urls = url_from_logs(log_file)
else:
    urls = create_url_list(target, inp_file)

Comment thread core/utils.py Outdated
pass
return sorted_headers

def url_from_logs(inp_file):
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call it parse_burp

Comment thread corsy.py Outdated
inp_file = args.inp_file
json_file = args.json_file
header_dict = args.header_dict
log_file = args.file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the position of this line according to it's length.

@s0md3v s0md3v added the enhancement New feature or request label Jan 17, 2020
@Yariayappayariayappa
Copy link
Copy Markdown

0xrishabh:ImportBurpLogs

Repository owner deleted a comment from Yariayappayariayappa Aug 31, 2022
Repository owner deleted a comment from Yariayappayariayappa Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants